Use php_info_print_table_header for actual column headers only #9485
Conversation
|
Before:
After:
|
|
The regex |
|
not a bug fix per say but sort of, so could it apply to a release branch, real question ? |
You mean "row", instead of "column"? |
Yes 🙂 |
|
Ah, nevermind. I understand now. Apparently I did not include all possible extensions in my local build. I've just verified the change by scrolling through the page. I'll also adjust the others. |
Using php_info_print_table_header() for "Foo: bar" looks odd and out of place, because the whole line is colored. It is also questionable from a HTML semantics point of view, because it does not described the columns that follow. The use of this across extensions is inconsistent. It was part of the skeleton, but ext/date or ext/json already use a regular row.
TimWolla
force-pushed
the
zend-test-phpinfo-formatting
branch
from
5f37fda to
fa31348
Compare
github-actions
bot
added
Extension: com_dotnet
Extension: ffi
Extension: intl
Extension: mysqli
Extension: mysqlnd
Extension: odbc
Extension: pcntl
Extension: pdo (core)
Extension: pdo_dblib
Extension: pdo_firebird
Extension: pdo_mysql
Extension: pdo_oci
Extension: pdo_odbc
Extension: pdo_sqlite
Extension: pgsql
Extension: phar
Extension: readline
Extension: sodium
Extension: spl
Extension: sqlite3
labels
TimWolla
changed the title
@devnexen Probably not worth it. Without invoking https://xkcd.com/1172 someone might attempt to parse @iluuu1994 I've made a sweeping change across all uses of |
4 participants
Using php_info_print_table_header() for "Foo: bar" looks odd and out of place,
because the whole line is colored. It is also questionable from a HTML
semantics point of view, because it does not described the columns that follow.
The use of this across extensions is inconsistent. It was part of the skeleton,
but ext/date or ext/json already use a regular row.