Skip to content

Improve DBA test suite #8904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 28, 2022
Merged

Improve DBA test suite #8904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3ec5ba9
Rework DBA tests
Girgias Jun 30, 2022
e4b74ec
Add individual CONFLICT sections to have parallel testing
Girgias Jun 30, 2022
2099328
Create a big matrix of creation test for DB4
Girgias Jul 1, 2022
0e5a017
Test lock file combination
Girgias Jul 1, 2022
0045faf
LMDB Uber slow transaction is fixed
Girgias Jul 1, 2022
8a23630
Move DB4 Matrix creation test to a function
Girgias Jul 1, 2022
f24e976
Add creation matrix test for other drivers
Girgias Jul 1, 2022
5d6d435
GDBM test
Girgias Jul 21, 2022
ff1685b
Drop XFAIL now the mem leak is fixed
Girgias Jul 21, 2022
e9b6d47
WIP pgsql test fix
Girgias Jul 21, 2022
26849b6
Cleanup + drop todo comment
Girgias Jul 22, 2022
fb576f8
Update test expectation after message update
Girgias Jul 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Cleanup + drop todo comment
  • Loading branch information
@Girgias
Girgias committed Jul 28, 2022
commit 26849b61aef5fd3b50b9a795a5891d8df8d29618
4 changes: 2 additions & 2 deletions ext/dba/tests/dba_array_keys_inifile.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ check_skip('inifile');
--FILE--
<?php
require_once __DIR__ . '/setup/setup_dba_tests.inc';
$name = 'array_keys_inifle.db';
$name = __DIR__ . '/array_keys_basic.db';

$db = dba_open($name, 'c', 'inifile');

Expand All @@ -28,7 +28,7 @@ dba_close($db);
--CLEAN--
<?php
require_once __DIR__ . '/setup/setup_dba_tests.inc';
$db_name = 'array_keys_basic.db';
$db_name = __DIR__ . '/array_keys_basic.db';
cleanup_standard_db($db_name);
?>
--EXPECTF--
Expand Down
2 changes: 0 additions & 2 deletions ext/dba/tests/setup/setup_dba_tests.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,6 @@ enum LockFlag: string {
case NoLock = '-';
}

// TODO Test which opens a NON DB file to check for memory leaks (at least LMDB has)

function set_up_db_ex(string $handler, string $name, LockFlag $lock, bool $persistent = false) {
$lock_flag = $lock->value;
// Open file in creation/truncation mode
Expand Down