Skip to content

mbstring requires pcre #8686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

mbstring requires pcre #8686

wants to merge 1 commit into from

Conversation

@remicollet
Copy link
Member

@remicollet remicollet commented Jun 2, 2022 •
edited
Loading

Fixing #8685
Adding this dependency ensure MINIT of pcre is run before MINIT of mbstring

mbstring calls OnUpdate_mbstring_http_output_conv_mimetypes => _php_mb_compile_regex => php_pcre_cctx

cmb69
cmb69 approved these changes Jun 2, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@remicollet
Copy link
Member Author

Thanks for the review.

Merged as 2eb2f9d

@remicollet remicollet closed this Jun 3, 2022
@remicollet remicollet deleted the issue-8685 branch June 3, 2022 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees

No one assigned

Labels

Extension: mbstring Quickfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@remicollet @cmb69 @nikic @saundefined