Skip to content

Phpsp test marcosptf #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Phpsp test marcosptf #861

wants to merge 5 commits into from

Conversation

rogeriopradoj
Copy link

@rogeriopradoj
Copy link
Author

Ping @Tyrael

@datibbaw
Copy link
Contributor

Why not just modify ext/standard/tests/strings/add-and-stripcslashes.phpt? In any case, test cases should be under ext/standard/tests and not tests/.

marcosptf - <marcosptf@yahoo.com.br>
#phptestfest PHPSP on Google - Sao Paulo - Brazil - 2014-06-05
--FILE--
<?php error_reporting(0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merely tests the warning system; it's redundant.

@rogeriopradoj
Copy link
Author

Hi, @marcosptf, can you update the tests in order to follow @datibbaw recommendations?

Call us if you need some local help, ok?

c/c @duodraco, @ivanrosolen

@marcosptf
Copy link
Contributor

Sr, this pr was changed to:
#880

@marcosptf
Copy link
Contributor

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants