Add BEGIN_EXTERN_C() and END_EXTERN_C() to .h files missing them. #840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zend_vm_opcodes.h is a generated file, could you please update the zend_vm_gen.php script too? |
|
Do all Zend headers need this, or only ones we know will be used in C++ code? |
|
@TazeTSchnitzel All, but most of them already do. This handles the three headers that did not. |
LawnGnome
force-pushed
the
zend-c++-compat
branch
from
25fc9d3 to
4bb836b
Compare
|
@bwoebi Done. Sorry; I missed the notification when you posted last month. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.php.net/bug.php?id=68091
This can be applied directly to PHP-5.5 and merged upwards.