Add missing ZPP checks in SPL Directory#8325
Merged
Girgias merged 3 commits intophp:masterfrom Apr 8, 2022
Merged
Conversation
Member
I think that test only catches issues regarding the wrong number of parameters. Since any parameter count is allowed, there's no issue reported. Anyhow, not sure about BC concerns with this PR. Of course, users shouldn't pass any arguments to these methods, but some may do. |
Member
Author
|
erf I forgot it only erros/warns in a debug build and not a release one. I was planing to consider this as a bugfix, but I'll rebase onto master and merge the other SPL stuff and add some comments to UPGRADING |
Girgias
force-pushed
the
spl-dir-zpp-miss
branch
from
813a1ed to
cba498b
Compare
kocsismate
reviewed
Apr 8, 2022
Co-authored-by: Máté Kocsis <kocsismate@woohoolabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out there are a couple of them, but very confused as to why the
Zend/tests/arginfo_zpp_mismatch.phpttest hasn't caught them.