Fix GH-8267: MySQLi uses unsupported format specifier on Windows#8268
Closed
cmb69 wants to merge 2 commits intophp:PHP-8.0from
Closed
Fix GH-8267: MySQLi uses unsupported format specifier on Windows#8268cmb69 wants to merge 2 commits intophp:PHP-8.0from
cmb69 wants to merge 2 commits intophp:PHP-8.0from
Conversation
Instead of using the unsupported `%I64u` and `%I64d` format specifiers on Windows, we use the portable `PRIu64` and `PRId64` specifiers. The `L64()` macro and the `my_longlong` typedef should be adapted as well, as the `i64` literal suffix is still supported by MSVC, but using `LL` or `ll` is recommended[1], and the standard `int64_t` is available there anyway. This is not urgent, though. [1] <https://docs.microsoft.com/en-us/cpp/cpp/numeric-boolean-and-pointer-literals-cpp?view=msvc-170#integer-literals>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using the unsupported
%I64uand%I64dformat specifierson Windows, we use the portable
PRIu64andPRId64specifiers.The
L64()macro and themy_longlongtypedef should be adapted aswell, as the
i64literal suffix is still supported by MSVC, but usingLLorllis recommended[1], and the standardint64_tis availablethere anyway. This is not urgent, though.
[1] https://docs.microsoft.com/en-us/cpp/cpp/numeric-boolean-and-pointer-literals-cpp?view=msvc-170#integer-literals