Closed
Conversation
Girgias
force-pushed
the
std-str-duplicate-apis
branch
from
d7947de to
623c4d0
Compare
Member
|
Dropping the string_natural_compare functions looks reasonable to me, but I think we might want to retain the tolower/toupper functions, as these were the historical APIs before the zend variants were introduced. (At least the upper variants are very new IIRC.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The to lower/upper functions are wrappers around the
zend_*versions.The
natural_compareones are wrappers forstrnatcmp_ex()which always returnSUCCESSand return the result of the comparison via an out argument, something which seems rather pointless.