Skip to content

Fix GH-7979: DatePeriod iterator advances when checking if valid #8175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-7979: DatePeriod iterator advances when checking if valid #8175

wants to merge 2 commits into from

Conversation

Nacoma
Copy link

@Nacoma Nacoma commented Mar 6, 2022

Fixes #7979

@Nacoma Nacoma changed the title GH-7979: iterator advances when checking if valid Fix GH-7979: iterator advances when checking if valid Mar 6, 2022
@Nacoma Nacoma changed the title Fix GH-7979: iterator advances when checking if valid Fix GH-7979: DatePeriod iterator advances when checking if valid Mar 6, 2022
cmb69
cmb69 reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! From a quick look, this fix looks reasonable.

@derickr, you may want to review.

@cmb69 cmb69 linked an issue Mar 30, 2022 that may be closed by this pull request
DatePeriod::getIterator()->valid() advances DatePeriod iterator #7979
Closed
@derickr derickr self-assigned this Apr 14, 2022
derickr added a commit that referenced this pull request Apr 14, 2022
@derickr
Merged pull request #8175
789f6b8
@derickr
Copy link
Member

derickr commented Apr 14, 2022

I've merged this after a little refactor to avoid duplicated code. Thanks for your patch!

@derickr derickr closed this Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69 cmb69 cmb69 left review comments

Assignees

@derickr derickr

Labels

Extension: date

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

DatePeriod::getIterator()->valid() advances DatePeriod iterator

3 participants

@Nacoma @derickr @cmb69