Skip to content

Fix GH-7883 don't close not open file handle #7956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix GH-7883 don't close not open file handle #7956

wants to merge 2 commits into from

Conversation

@remicollet
Copy link
Member

See #7883

@remicollet remicollet mentioned this pull request Jan 17, 2022
Closed
@remicollet
Copy link
Member Author

First commit is belt, second is braces (and minor optimization)

@cmb69
Copy link
Member

cmb69 commented Jan 17, 2022

See also #7929; I think we need to revert parts of c732ab4.

@remicollet
Copy link
Member Author

@dstogov as the author of c732ab4 please check this quickfix

@remicollet
Copy link
Member Author

Merged as cdfc4d3

@cmb69 I think #7929 can be handled separately

@remicollet remicollet closed this Jan 18, 2022
@remicollet remicollet deleted the issue-7883 branch January 18, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Bug Quickfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remicollet @cmb69