Skip to content

Deprecate zend_atol() / add zend_ini_parse_quantity() #7951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 17, 2022
Merged

Deprecate zend_atol() / add zend_ini_parse_quantity() #7951

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
1e18442
Add zend_ini_parse_quantity() and deprecate zend_atol(), zend_atoi()
arnaud-lb Jan 14, 2022
6e4b86f
Migrate zend_atol() calls to ZEND_ATOL() or zend_ini_parse_quantity()
arnaud-lb Jan 14, 2022
2a37b1d
Improve wording
arnaud-lb Jun 4, 2022
1ea1893
Add tests
arnaud-lb Jun 4, 2022
57113ba
zend_is_whitespace as a function
arnaud-lb Jun 4, 2022
a779737
Null safety
arnaud-lb Jun 4, 2022
7ecb928
Handle overflows
arnaud-lb Jun 5, 2022
5ee34a5
Symbol visibility
arnaud-lb Jun 5, 2022
cc1b7f0
Tests
arnaud-lb Jun 10, 2022
a2a87fa
Add comment
arnaud-lb Jun 10, 2022
54b1952
Deduplicate warnings
arnaud-lb Jun 10, 2022
deaeded
[ci skip] UPGRADING
arnaud-lb Jun 10, 2022
c356791
WS
arnaud-lb Jun 10, 2022
8f6c1b6
Fix tests
arnaud-lb Jun 10, 2022
69e6ff4
Add test
arnaud-lb Jun 17, 2022
e6d303f
Avoid boolean arg for clarity
arnaud-lb Jun 17, 2022
1d4dfa5
Avoid UB
arnaud-lb Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@arnaud-lb
arnaud-lb committed Jun 17, 2022
commit 69e6ff46a120a2eeb602e8f22b628ee3d1e64db0
13 changes: 13 additions & 0 deletions Zend/tests/zend_ini_parse_quantity_ini_setting_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
--TEST--
Test ini setting with invalid quantity
--EXTENSIONS--
zend_test
--INI--
zend_test.quantity_value=1MB
--FILE--
<?php

var_dump(ini_get("zend_test.quantity_value"));
--EXPECTF--
Warning: Invalid "zend_test.quantity_value" setting. Invalid quantity "1MB": unknown multipler "B", interpreting as "1" for backwards compatibility in %s on line %d
string(3) "1MB"