Bug 67634 #790
Closed
Bug 67634 #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated link. |
|
I don't understand why it needs to clone the object. I can understand that getTimestamp() shouldn't modify the object, but this patch hides the issue, and doesn't fix it. I think the bug is somewhere else (like, in not updating the timestamp after modify, or not resetting all "relative" elements after calling modify)/ |
|
Since this has been rejected by the timelib maintainer, and would appear to have been abandoned by the author (no response to comments), I'm closing this PR. Please take this action as encouragement to open a clean PR, addressing the issues raised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.php.net/bug.php?id=67634
Create clone of object instead of updating the values of the original object