Fix #81693: mb_check_encoding(7bit) segfaults#7712
Closed
cmb69 wants to merge 2 commits intophp:PHP-8.1from
Closed
Fix #81693: mb_check_encoding(7bit) segfaults#7712cmb69 wants to merge 2 commits intophp:PHP-8.1from
cmb69 wants to merge 2 commits intophp:PHP-8.1from
Conversation
`php_mb_check_encoding()` now uses conversion to `mbfl_encoding_wchar`. Since `mbfl_encoding_7bit` has no `input_filter`, no filter can be found. Since we don't actually need to convert to wchar, we encode to 8bit.
alexdowad
approved these changes
Dec 3, 2021
Contributor
alexdowad
left a comment
alexdowad
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
Contributor
|
this doesn't look right? https://3v4l.org/HZh8A |
Contributor
|
@divinity76, thanks for reporting... will look at that soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_mb_check_encoding()now uses conversion tombfl_encoding_wchar.Since
mbfl_encoding_7bithas noinput_filter, no filter can befound. Since we don't actually need to convert to wchar, we encode to
8bit.