Skip to content

Add more specific array return type hints for various extensions - part 2 #7433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kocsismate
Copy link
Member

ext/ftp, ext/gmp, ext/intl

@krakjoe krakjoe added the Type Information Label should be used whenever a pull request is working to improve type information for core or o+ label Aug 31, 2021
@kocsismate kocsismate changed the base branch from master to PHP-8.1 September 5, 2021 18:52
@kocsismate kocsismate force-pushed the stub-array-3 branch 2 times, most recently from cfc74ee to 3c6e9ec Compare September 6, 2021 10:24
Copy link
Member

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok, with the same note as last time regarding methods. Or are they needed in this case to make the @alias validation happy? In that case it's fine.

@kocsismate
Copy link
Member Author

Looks ok, with the same note as last time regarding methods. Or are they needed in this case to make the alias validation happy? In that case it's fine.

Yeah, these are only necessary for the validation. Thanks for the quick check!

@kocsismate kocsismate deleted the stub-array-3 branch November 17, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type Information Label should be used whenever a pull request is working to improve type information for core or o+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants