Implement Fiber GC handler #7203
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a GC handler to avoid memory leaks when a fiber
callback(orresult) holds a reference to theFiberobject. The following example produces a memory leak without proper GC handler:The leak occurs because the
Fiberis never started and it cannot be garbage collected due to thecallbackholding a reference to theFiberobject (this will also happen for transitive / nested references).This example will also leak memory due to the
Fiberreferencing itself from it'sresult. This PR addresses both leaks by providing aget_gcobject handler and 2 additional tests that cover the demonstrated memory leaks.