Enable net_get_interfaces on IBM i PASE #7136
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On IBM i, getifaddrs is available renamed as Qp2getifaddrs; freeifaddrs and struct ifaddr follow a similar fate. I assume this is in case AIX decides to add it (as if). As such, just use the same implementation, but rename the standard ones to the IBM i definitions and include its header. On PHP 7.x, an ifdef to basic_functions.c is also needed, otherwise the function will not be registered. Technically, the fact PHP 8 always registers this function is a bug, but hasn't been caught, it seems.
krakjoe
added a commit
that referenced
this pull request
Jun 11, 2021
krakjoe
added a commit
that referenced
this pull request
Jun 11, 2021
* PHP-8.0: fix bad refactor of #7136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On IBM i,
getifaddrsis available renamed asQp2getifaddrs;freeifaddrsandstruct ifaddrfollow a similar fate. I assume this is in case AIX decides to add it (as if). As such, just use the same implementation, but rename the standard ones to the IBM i definitions and include its header.On PHP 7.x, an ifdef to
basic_functions.cis also needed, otherwise the function will not be registered. Technically, the fact PHP 8 always registers this function is a bug, but hasn't been caught, it seems.