Skip to content

Conversation

@krakjoe
Copy link
Member

@krakjoe krakjoe commented Jun 7, 2021

@nikic very unsure if this is right, is it ?

@nikic
Copy link
Member

nikic commented Jun 8, 2021

I expect this may not handle the skip_frame/fake_frame right. I think a way to test is from inside an error handler on include() failure, where there should be a fake include() frame.

I think correctly handling all the edge cases may not be simple.

@krakjoe
Copy link
Member Author

krakjoe commented Jun 8, 2021

Bravely, backing out ...

@krakjoe krakjoe closed this Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants