Fix bug #81096: Re-infer ranges if ref type is inferred #7114
+113
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a reference type for a variable is inferred, the range information becomes potentially incorrect, as the variable may be modified indirectly at any time. If a reference type is inferred, set the variable to the full range and recompute dependent ranges. This is done using a separate range worklist that calculates ranges using a widening meet. Fix for https://bugs.php.net/bug.php?id=81096.
|
I think, it should be a better way to fix this. I'll try to take a look. |
twose
reviewed
Jun 8, 2021
| range_worklist = do_alloca(sizeof(zend_ulong) * zend_bitset_len(ssa_vars_count), use_heap); | ||
| memset(range_worklist, 0, sizeof(zend_ulong) * zend_bitset_len(ssa_vars_count)); | ||
| range_worklist = worklist + worklist_len; | ||
| memset(range_worklist, 0, sizeof(zend_ulong) * worklist_len); |
There was a problem hiding this comment.
It seems that memset can also be combined too.
|
Fixed in different way by #7121. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a reference type for a variable is inferred, the range
information becomes potentially incorrect, as the variable may
be modified indirectly at any time.
If a reference type is inferred, set the variable to the full
range and recompute dependent ranges. This is done using a separate
range worklist that calculates ranges using a widening meet.
Fix for https://bugs.php.net/bug.php?id=81096.