Move FTP extension class FTPConnection to FTP\Connection#6960
Merged
nikic merged 1 commit intophp:masterfrom May 8, 2021
Merged
Move FTP extension class FTPConnection to FTP\Connection#6960nikic merged 1 commit intophp:masterfrom
FTPConnection to FTP\Connection#6960nikic merged 1 commit intophp:masterfrom
Conversation
With the [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) passed, renaming the new `\FTPConnection` class to `\FTP\Connection`. This also adds an entry to `./UPGRADING` file. Related: php#6925, php#5945
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions) RFC. Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
Ayesh
added a commit
to Ayesh/php-src
that referenced
this pull request
May 8, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: php#6925, php#5945, php#6960
nikic
pushed a commit
that referenced
this pull request
May 9, 2021
Another change as per accepted [namespaces in bundled extensions RFC](https://wiki.php.net/rfc/namespaces_in_bundled_extensions). Related: #6925, #5945, #6960
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the namespaces in bundled extensions RFC passed, renaming the new
\FTPConnectionclass to\FTP\Connection.This also adds an entry to
./UPGRADINGfile.Related: #6925, #5945