Fix #62004: SplFileObject: fgets after seek returns wrong line #6434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think fixing this in PHP 8.0 only, with a possible upgrading mention might make sense. |
As it is, `::seek(0)` sets the file pointer to the beginning of the file, but `::seek($n)` where `$n > 0` sets the file pointer to the beginning of the following line, having line `$n` already read into the line buffer. This is pretty inconsistent; we fix it by always seeking to the beginning of the line.
|
Given that the bug has been reported more than seven years ago, there seems no need to hurry, so I've rebased onto PHP-8.0. @sgolemon, @carusogabriel, are you fine with this landing in 8.0.1? If we target the "master" branch only, I think an alternative solution which does not actually store every line temporarily in memory would be preferable. |
php-pulls
pushed a commit
to php/doc-en
that referenced
this pull request
Nov 30, 2020
Cf. <php/php-src#6434>. git-svn-id: https://svn.php.net/repository/phpdoc/en/trunk@351790 c90b9560-bf6c-de11-be94-00142212c4b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is,
::seek(0)sets the file pointer to the beginning of thefile, but
::seek($n)where$n > 0sets the file pointer to thebeginning of the following line, having line
$nalready read into theline buffer. This is pretty inconsistent; we fix it by always seeking
to the beginning of the line.
Frankly, I'm not really sure how that is supposed to behave. While
SplFileObject::fgets()is documented as "returns a string containing the next line from the file", its aliasSplFileObject::getCurrentLine()suggests otherwise. Anyway, the current behavior makes no sense. However, given the need to change other test cases suggest that a fix might better target PHP-8.0 or the master branch.