Skip to content

Update ext/xml parameter names #6297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update ext/xml parameter names #6297

wants to merge 1 commit into from

Conversation

nikic
Copy link
Member

@nikic nikic commented Oct 8, 2020

A surprisingly pleasant extension... I'm keeping the $handler terminology, as these are not proper "callables", and we also have it in all the API names.

@nikic nikic requested a review from kocsismate October 8, 2020 08:03
@nikic
Copy link
Member Author

nikic commented Oct 8, 2020

Only thing I was unsure about here was the $index in xml_parse_into_struct(). However, I think $index is a pretty accurate description here, with the caveat that it's the non-computer-science meaning of the word.

@nikic nikic mentioned this pull request Oct 8, 2020
Closed
65 tasks
kocsismate
kocsismate approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@kocsismate kocsismate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using $handler and $index makes sense to me!

@php-pulls php-pulls closed this in c05898d Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocsismate kocsismate kocsismate approved these changes

Assignees
No one assigned
Labels
Parameter names
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikic @kocsismate