-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Update ext/posix parameter names #6275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I guess for this extension the main open question is whether we should use things like |
There is already a use of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using $uid
and $gid
is ok from my side. There is a $pgid
though, which is slightly beyond my limits, but I can live with it. Also, I saw that there are a couple of $fd
parameters. Unless I'm missing that it's a very general abbreviation, I'd prefer $file_descriptor
.
ext/posix/posix.stub.php
Outdated
|
||
#ifdef HAVE_INITGROUPS | ||
function posix_initgroups(string $name, int $base_group_id): bool {} | ||
function posix_initgroups(string $username, int $base_group_id): bool {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does $base_group_id
really require the $base
prefix? What about just $gid
to make it consistent with the rest of the parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Man page says:
The initgroups() function initializes the group access list by reading the group database /etc/group and using all groups of which user is a member. The additional group group is also added to the list.
So yeah, I have no idea what the base_
prefix is even supposed to mean, I'll drop it.
Yeah, I also had to look up what pgid means :) Personally I'm leaning towards using the longer names here...
Maybe we just want to call these |
👍 Overall, I'm happy to hear it!
I like |
I went with |
No description provided.