Update ext/tokenizer param names #6232
Conversation
ext/tokenizer/tokenizer.stub.php
Outdated
| function token_get_all(string $code, int $flags = 0): array {} | ||
|
|
||
| function token_name(int $token): string {} | ||
| function token_name(int $token_id): string {} |
There was a problem hiding this comment.
Why not just $name or $id?
There was a problem hiding this comment.
Ops, I didn't see your comment :)
ext/tokenizer/tokenizer.stub.php
Outdated
| function token_get_all(string $code, int $flags = 0): array {} | ||
|
|
||
| function token_name(int $token): string {} | ||
| function token_name(int $token_id): string {} |
There was a problem hiding this comment.
I would be ok with $id too. E.g. filter_id() uses $name :D But I'm ok with using $token_id here, or changing $name to $filter_name in filter_id()
|
One more comment: |
In this case the |
Thanks for the clarification! Then everything looks good now :) |
3 participants
No description provided.