Skip to content

Fix wrong datatype #6028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix wrong datatype #6028

wants to merge 1 commit into from

Conversation

manuelm
Copy link
Contributor

@manuelm manuelm commented Aug 21, 2020

ini_entry->modifiable is of type uint8_t and so should be the temp. variable. Especially important after 4b77a15.

@manuelm
Fix wrong datatype
fb69fee 
ini_entry->modifiable is of type uint8_t and so should be the temp. variable. Especially important after 4b77a15.
cmb69
cmb69 approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, indeed! modifiable is not a boolean, but rather more like an enum.

@php-pulls php-pulls closed this in 46d62e5 Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmb69 cmb69 cmb69 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelm @cmb69