Skip to content

Convert resources to objects in ext/sockets#5900

Closed
kocsismate wants to merge 8 commits intophp:masterfrom
kocsismate:resource-sockets
Closed

Convert resources to objects in ext/sockets#5900
kocsismate wants to merge 8 commits intophp:masterfrom
kocsismate:resource-sockets

Conversation

@kocsismate
Copy link
Member

No description provided.

@kocsismate kocsismate marked this pull request as draft July 27, 2020 22:55
@Girgias
Copy link
Member

Girgias commented Jul 28, 2020

Compile error:

/home/vsts/work/1/s/ext/sockets/sockets.c:937:14: error: unused variable ‘php_sock’ [-Werror=unused-variable]
  937 |  php_socket *php_sock;
      |              ^~~~~~~~

@kocsismate kocsismate added this to the PHP 8.0 milestone Jul 30, 2020
@kocsismate kocsismate marked this pull request as ready for review August 2, 2020 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants