Respect the $YACC environment variable. #497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure why you make a PR out of it? :) |
|
@m6w6 I don't have Zend karma. (Which is something I keep meaning to chase up and haven't.) |
|
I cherry-picked the ci in master, seems your patch missed a tail 'g' in the regex pattern :) thanks |
|
Bah. Sorry about the g, and thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes is effectively in master already, but should be backported to 5.4 and 5.5 to make compilation easier on OS X (which ships with a now-unsupported version of bison). This merges up to PHP-5.5 cleanly, and can be merged into master with an easily resolved conflict.