Unbundle libtool #4359
Unbundle libtool #4359
Conversation
|
|
||
| if test -z "$libtoolize_version"; then | ||
| echo "buildconf: libtoolize not found." >&2 | ||
| echo " You need libtoolize version 2.4.6 or newer installed" >&2 |
There was a problem hiding this comment.
RHEL / CentOS 7 still have 2.4.2, would be nice to accept this version
| m4_include([build/m4/ltoptions.m4]) | ||
| m4_include([build/m4/ltsugar.m4]) | ||
| m4_include([build/m4/ltversion.m4]) | ||
| m4_include([build/m4/lt~obsolete.m4]) |
There was a problem hiding this comment.
This looks pretty fragile when it comes to supporting different libtool versions. Is it necessary to explicitly include all of these?
|
@nikic, @remicollet, @derickr just a quick question here. July 22nd is feature freeze for PHP-7.4. I'm not sure I can make the libtool upgrade till then. I mean, I can fix these obvious mentioned issues and introduce also the aclocal tool dependency back (to not have gazillions of m4_include() usages) in the process but to properly test it might take a bit longer. Would be upgrading libtool (and introducing two new dependencies in PHP build step) considered an issue if we extend this one after feature freeze? Here we're talking about the libtool (and its libtoolize tool) and automake (and its aclocal which can do that what is asked above a bit). Also interesting fact is that PHP build system very long time ago removed the aclocal dependency so building configure script is a bit simpler. |
|
I would be much happier if we leave this for PHP 8. TBH, I am not sure whether it is wise to unbundle libtool at all actually. |
|
I'd prefer to leave this to PHP 8 as well. It's a pretty big build system change and I don't think there's a strong need to land it in 7.4. |
|
Then, I think it's best to continue with something like #4358 and target PHP 8 together with ditching the autotools completely in one of the PHP 8.x versions (migration to CMake). In any case, with unbundling we'll be introducing the libtoolize (and possibly automake) dependencies back. I'm not sure that's a good idea considering where PHP build system was trying to go from the initial steps to today. Hopefully, current bundled libtool in PHP 7.4 will do for a minimum period of 3+ years... 🤞 |
Hello, this is same as #4358 except that this unbundles libtool and uses system version. Here additional dependency is required to build PHP from Git. Release would include all needed scripts in the archive so libtool there is not needed (same as autoconf tool).