Request #72189 Add missing CURL_VERSION_* constants
#4093
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikic
reviewed
Apr 30, 2019
phansys
force-pushed
the
issue_72189
branch
3 times, most recently
from
d97ed06 to
3f51936
Compare
phansys
changed the title
CURL_VERSION_* and CURLVERSION_* constantsCURL_VERSION_* constants
phansys
force-pushed
the
issue_72189
branch
3 times, most recently
from
e18cf53 to
598ca5f
Compare
nikic
reviewed
May 1, 2019
|
I believe we should update Line 539 in 572218d |
nikic
reviewed
May 2, 2019
nikic
reviewed
May 2, 2019
ext/curl/interface.c
Outdated
| REGISTER_CURL_CONSTANT(CURL_VERSION_SSPI); | ||
|
|
||
| #if LIBCURL_VERSION_NUM >= 0x071306 /* Available since 7.19.6 */ | ||
| REGISTER_CURL_CONSTANT(CURL_VERSION_CURLDEBUG); |
There was a problem hiding this comment.
As this is an old constant, I wonder if it was omitted intentionally. The curl docs do say "This is mainly of interest for libcurl hackers". But I don't see any particular problem with exposing it either...
There was a problem hiding this comment.
ping @bagder for thoughts about exposing it
There was a problem hiding this comment.
It's indeed part of the public API, exposed to the world just like the other bits there so I have no objections.
If it actually is useful to anyone is another matter...
|
Merged as 6b73e69 into 7.3+. Thanks! |
phansys
added a commit
to phansys/php-src
that referenced
this pull request
May 3, 2019
php-pulls
pushed a commit
that referenced
this pull request
May 3, 2019
php-pulls
pushed a commit
that referenced
this pull request
May 3, 2019
* PHP-7.3: Update `NEWS` with changes made at #4093
php-pulls
pushed a commit
that referenced
this pull request
May 3, 2019
* PHP-7.4: Update `NEWS` with changes made at #4093
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
sync-constants.php;Relates to request #72189.