Clean up .diff, .out and .log from tests #3075
Conversation
|
Hmm what about exp files too? Maybe I can do something similar for Windows when I'm back tomorrow |
|
@KalleZ There are some cases under GIT, like https://github.com/php/php-src/blob/master/ext/mbstring/libmbfl/tests/conv_encoding.tests/ujis_sjis.exp 😢 |
Makefile.global
Outdated
| find . -name \*.gcno -o -name \*.gcda | xargs rm -f | ||
| find . -name \*.lo -o -name \*.o | xargs rm -f | ||
| find . -name \*.la -o -name \*.a | xargs rm -f | ||
| find . -name \*.diff -o -name \*.diff | xargs rm -f |
There was a problem hiding this comment.
The -o means "or", so putting the same thing on both sides doesn't make much sense ^^ Maybe find . -name \*.diff -o -name \*.out -o -name \*.log | xargs rm -f?
There was a problem hiding this comment.
Always teaching me, thanks 😄
Makefile.global
Outdated
| find . -name \*.gcno -o -name \*.gcda | xargs rm -f | ||
| find . -name \*.lo -o -name \*.o | xargs rm -f | ||
| find . -name \*.la -o -name \*.a | xargs rm -f | ||
| find . -name \*.diff -o -name \*.out -o -name \*.log | xargs rm -f |
There was a problem hiding this comment.
This will also catch some unrelated stuff, like config.log. This probably needs to be restricted to tests/ directories or something.
There was a problem hiding this comment.
I removed this for now, keeping only *.diff and *.out. I'll figure out a better clean scripts for our tests so we can even include *.php and *.exp as well :)
|
I don't think this PR makes sense in the current form. Either we should be removing all test artifacts, or none of them. Just dropping two out of something like six files seems neither here nor there. |
|
@nikic Closing for now. I'll search a pattern for test folders and its files and how to remove them without touch others |
|
I'm also not totally sure if we should be doing this at all. The main purpose of |
4 participants
AFAICT is safety in clean them, and there are a lot of them usually 😅