In some systems, net/if.h needs sys/socket.h for sockaddr type, #2992
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thus led to detection failure of this particular header.
|
Would be kind to backport it as well. |
|
Please target the lowest applicable branch: If this patch does not merge with other branches, please open separate requests for those branches. |
|
Fair point will do. |
|
Forget backporting ... it applies only here. Apologies. |
|
What is the system where this fails currently? |
|
OpenBSD :-) was frustrating having this constant never set while it genuinely exists (but looking at the config.log I saw it was because struct sockaddr was missing. |
|
Thanks. I think it would be good to also fix this upstream in OpenBSD -- this sounds like a bug to me (at least a POSIX non-compliance issue). |
|
Merged as a95e8b8, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thus led to detection failure of this particular header.