report about OpenSSL 1.1 not supported during configure #2394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Majkl578
reviewed
Feb 21, 2017
acinclude.m4
Outdated
| OPENSSL_INCDIR=`$PKG_CONFIG --variable=includedir openssl` | ||
| else | ||
| AC_MSG_ERROR([OpenSSL version 0.9.8 or greater required.]) | ||
| AC_MSG_ERROR([OpenSSL version >= 0.9.8 and <= 1.1.0 required.]) |
remicollet
force-pushed
the
issue-ssl
branch
from
97a82f3 to
e3e41e5
Compare
|
LGTM, just make sure that it's not merged up to 7.1... :) |
|
@weltling can you merge this into 7.0 please ? |
|
Comment on behalf of remi at php.net: merged |
|
I would have liked some input from Anatol before that was merged. |
|
Looks fine AFM, better to fail hard with a clear message on unsupported version. I would've merged next day, as it didn't look urgent. Thanks for taking care. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As only PHP 7.1+ supports OpenSSL 1.1 new API.
Other way, is to fix 7.0 to support it ;)