Prevent "make install" clobbering configuration for pre-existing installations; remove error ignore #2393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default php-fpm.d/* is included in the config. Writing anything there will break most existing PHP applications. Also, $(INSTALL_DATA) won't return unnecessary errors, so don't ignore them. If installation of something is part of make install, and it doesn't happen, it should fail. ( || : at the end removed)
Edited in github editor... changed spaces to tabs
Missed some spaces for the tab-nazi
One space too many
Build error messages aren't very clear. Trying to figure out build environment and getting it to build without ignoring the shtool install errors...
dagelf
changed the title
|
Merged 9eaf551 Thanks. |
|
Just to double-check, @remicollet, is this indeed how it should work per standard conventions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default php-fpm.d/* is included in the config. Writing anything there will break most existing PHP applications, so it should be skipped if installing into an existing environment.
Package maintainers generally build in a clean environment, so shouldn't be affected.
Also, $(INSTALL_DATA) won't return unnecessary errors, so don't ignore them. If installation of something is part of make install, and it doesn't happen, it should fail. ( || : at the end removed)