fix bug #50989 #2346
Closed
fix bug #50989 #2346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged 2fcf125 Thanks. |
php-pulls
pushed a commit
that referenced
this pull request
Jan 30, 2017
php-pulls
pushed a commit
that referenced
this pull request
Jan 30, 2017
* pull-request/2348: fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)
php-pulls
pushed a commit
that referenced
this pull request
Jan 30, 2017
* PHP-7.0: fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)
php-pulls
pushed a commit
that referenced
this pull request
Jan 30, 2017
* PHP-7.1: fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)
dstogov
added a commit
to zendtech/php-src
that referenced
this pull request
Feb 1, 2017
* master: (78 commits) bump versions for next in dev removed additional ";" from run-tests.php Remove zend_version() checks from tests Remove ZEND_CHANGES and README.namespaces update NEWS update NEWS Securely zero the hash context key Fixed bug #73983 crash on finish work with phar in cli + opcache fix BC break introduced by php#2346 (sebastianbergmann/phpunit#2454) move id initialization into ctor fix system id initialization for multiple threads Try fpm path for testing in sbin as it is default target FTP: implement MLSD for structured listing of directories, decribed at https://tools.ietf.org/html/rfc3659 fixed bug #50989 (DOM support for LIBXML_NOXMLDECL) [ci skip] news entry for Fixed bug #73987 [ci skip] news entry for Fixed bug #73987 Added tests demonstrating the same effect with abstracts Inheritance checks should not ignore parents if these implement an interface NEWS Add test coverage for bug #72969 ...
php-pulls
pushed a commit
that referenced
this pull request
Feb 1, 2017
)" This reverts commit 62938bf.
php-pulls
pushed a commit
that referenced
this pull request
Feb 1, 2017
* PHP-7.0: sync NEWS with the reverted stuff Revert "fixed bug #50989 (DOM support for LIBXML_NOXMLDECL)" Revert "fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)"
php-pulls
pushed a commit
that referenced
this pull request
Feb 1, 2017
* PHP-7.1: remove the reverted NEWS entry sync NEWS with the reverted stuff Revert "fixed bug #50989 (DOM support for LIBXML_NOXMLDECL)" Revert "fix BC break introduced by #2346 (sebastianbergmann/phpunit#2454)"
php-pulls
pushed a commit
that referenced
this pull request
Feb 1, 2017
)" This reverts commit 62938bf.
php-pulls
pushed a commit
that referenced
this pull request
Feb 1, 2017
)" This reverts commit 62938bf.
|
We are fine with this feature, in principle, but in reality it broke many things that we are not testing right now. I'd be happy to see another attempt at this feature. |
|
Yeah, to give more background, here are the further test fails in the Horde test suite. https://apps.fedoraproject.org/koschei/package/php-horde-Horde-Text-Filter?collection=f26 The behavior change introduced causes XML entity conversion in this case, where only LIBXML_NOXMLDECL was intended. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.