Remove extraneous parentheses in conditions

[dereckson]

This fixes nine clang/llvm parentheses-equality warnings.

Example of warning

Zend/zend_vm_execute.h:59845:25: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
                        } else if ((op1_info == MAY_BE_LONG)) {
                                    ~~~~~~~~~^~~~~~~~~~~~~~
Zend/zend_vm_execute.h:59845:25: note: remove extraneous parentheses around the comparison to silence this warning
                        } else if ((op1_info == MAY_BE_LONG)) {
                                   ~         ^             ~
Zend/zend_vm_execute.h:59845:25: note: use '=' to turn this equality comparison into an assignment
                        } else if ((op1_info == MAY_BE_LONG)) {
                                             ^~
                                             =

[KalleZ]

You should update the zend_vm_execute.skl && zend_vm_gen.php instead, else its overridden the next time the executor is generated :)

[dereckson]

Er, yes, it's indeed not really useful to correct an autogenerated file. Thanks to have pointed the source.

[dereckson]

So, I've added to zend_vm_gen.php an helper function format_condition to add () only when needed, ie when the condition isn't already (...).

[krakjoe]

Why target 7.1 ?

[php-pulls]

Comment on behalf of krakjoe at php.net:

labelling

[nikic]

@krakjoe This code has only been added in PHP 7.1.

[krakjoe]

If only I had read it properly, I see all the MAY_BE now ... thanks @nikic

[dereckson]

@krakjoe Yes, the patch doesn't apply to 7.0 branch as zend_vm_set_opcode_handler_ex function didn't exist. It has been introduced at fc7cbdc, a squashed commit including f4475a2.

[php-pulls]

Comment on behalf of pollita at php.net:

Closed by 5d7c774