fix null pointer dereference in php_mail_detect_multiple_crlf via error_log #20862
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordikroon
force-pushed
the
fix/gh20858
branch
from
dc75e05 to
93f25d8
Compare
Member
|
nice but be mindful next times when a ticket had been assigned already. |
Contributor
Author
|
Sorry for that @devnexen. I should have put a comment before working on it. I can't self assign myself unfortunately. |
Member
|
it s fine no big deal. Cheers. |
devnexen
reviewed
Jan 7, 2026
jordikroon
force-pushed
the
fix/gh20858
branch
3 times, most recently
from
08b1619 to
11f4730
Compare
jordikroon
force-pushed
the
fix/gh20858
branch
from
11f4730 to
51cc3dd
Compare
devnexen
reviewed
Jan 7, 2026
devnexen
approved these changes
Jan 7, 2026
Member
devnexen
left a comment
devnexen
left a comment
There was a problem hiding this comment.
the fix itself looks good, but I ll let it live for a while, e.g. tests might need updates/changes.
Contributor
Author
|
Thank you all for your feedback. And for going through my learning experience 😅 Much appreciated. |
Girgias
reviewed
Jan 9, 2026
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
I was planning on refactoring that code a bit more, mainly adding a warning that the to param is required for the email mode. But that is a reasonable fix for the time being.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20858