Fix GH-20370: forbid user stream filters to violate typed property constraints #20373
Conversation
alexandre-daubois
force-pushed
the
user-stream-filter-props
branch
from
b0808ce to
786ad32
Compare
alexandre-daubois
force-pushed
the
user-stream-filter-props
branch
from
786ad32 to
2ad8c64
Compare
There was a problem hiding this comment.
On a phone , so can't check. But you're looking at the property info now, however dynamic properties don't have any. So that means that a dynamically created property $stream would've been overwritten before this patch but now no longer. So that is an unintended behaviour change.
|
Oh alright, I wasn't aware of this subtlety of dynamic properties. Let's refine that. |
|
Hmm so that would require to someone create the dynamic property in filter first and it could then be used in subsequent calls for stream, right? If so, that sounds like a proper edge case... :) |
|
The easiest way to test this is to create a onCreate method that sets a dynamic property on $this |
| Warning: fwrite(): Unprocessed filter buckets remaining on input brigade in %s on line %d | ||
| TypeError: Cannot assign resource to typed property | ||
|
|
||
| Fatal error: Uncaught TypeError: Cannot assign resource to property pass_filter::$stream of type int in %s |
There was a problem hiding this comment.
I'm confused - the TypeError: Cannot assign resource to typed property presumably comes from the manual echo on line 29, so where does this uncaught fatal error come from?
There was a problem hiding this comment.
Also why is there a manual echo in the first place instead of echoing the value of getMessage() ?
There was a problem hiding this comment.
I reworked the test file
alexandre-daubois
force-pushed
the
user-stream-filter-props
branch
from
2ad8c64 to
fe4961a
Compare
|
This will work, except for a pre-existing bug: It would also be great to try to avoid OBJPROP so that the property table isn't rebuilt, but that isn't critical. |
|
I tried to implement what you have in mind in 04e0955 |
alexandre-daubois
force-pushed
the
user-stream-filter-props
branch
from
22d1292 to
7208c60
Compare
alexandre-daubois
force-pushed
the
user-stream-filter-props
branch
from
7208c60 to
04e0955
Compare
4 participants
Use
zend_update_property()instead of doing things "manually".