zend_object_handler.c: call zend_get_call_trampoline_func() directly #20297
+18
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abstracting away the bool parameter is not that useful, and doesn't make the code more legible. So just get rid of them and call the function with the boolean parameter directly.
Every single callsite already checks if it set to call this function, so no need to duplicate the work
TimWolla
requested changes
Oct 26, 2025
|
|
||
| ZEND_API zend_function *zend_get_call_trampoline_func(const zend_class_entry *ce, zend_string *method_name, bool is_static) /* {{{ */ | ||
| ZEND_API ZEND_ATTRIBUTE_NONNULL zend_function *zend_get_call_trampoline_func( | ||
| const zend_function *magic_call, zend_string *method_name, bool is_static) /* {{{ */ |
There was a problem hiding this comment.
The is_static parameter should also go away then.
There was a problem hiding this comment.
It is used to add a flag within the function body, and there is no convenient way to extract this information otherwise.
There was a problem hiding this comment.
You should be able to take this from magic_call->common.fn_flags just like the attribute flags.
dstogov
reviewed
Oct 27, 2025
|
I'm in favor if we can get rid of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstracting away the bool parameter is not that useful, and doesn't make the code more legible.
So just get rid of them and call the function with the boolean parameter directly.