Add NoDiscard attribute for Uri::with*() and Url::with*() methods #20209
+151
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kocsismate
requested review from
DanielEScherzer,
derickr,
edorian and
nielsdos
TimWolla
reviewed
Oct 19, 2025
|
|
||
| public function getScheme(): string {} | ||
|
|
||
| #[\NoDiscard(message: "as Uri\Rfc3986\Uri::withScheme() does not modify the object itself")] |
There was a problem hiding this comment.
This message is referring to the wrong class (same below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some wither tests are going to fail.. but I'd like to merge #19970 first and then rebase this one instead of fixing the warnings.