Fix test on 8.4+ #20196
Merged
Fix test on 8.4+ #20196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
approved these changes
Oct 16, 2025
ext/pdo_mysql/tests/gh20122.phpt
Outdated
Comment on lines
16
to
17
| $db->exec('CREATE TABLE test (bar JSON)'); | ||
| $db->exec('INSERT INTO test VALUES("[]")'); |
There was a problem hiding this comment.
Would also be nice to make the tests parallelable by not using test as the table name
nielsdos
requested review from
SakiTakamachi and
kamil-tekiela
as code owners
nielsdos
added a commit
that referenced
this pull request
Oct 17, 2025
* PHP-8.4: Fix test on 8.4+ (#20196)
nielsdos
added a commit
that referenced
this pull request
Oct 17, 2025
* PHP-8.5: Fix test on 8.4+ (#20196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I love it when the test suite gets refactored