Zend/Optimizer: use uint32_t types instead of int, add a few const qualifiers and comments.
#20017
+27
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
commented
Sep 30, 2025
| int level; /* steps away from the entry in the dom. tree, or -1 */ | ||
| int children; /* list of dominated blocks, or -1 */ | ||
| int next_child; /* next dominated block, or -1 */ | ||
| int successors_storage[2]; /* up to 2 successor blocks */ |
There was a problem hiding this comment.
So on 64 bit we have 4 bits of padding remaining, does it make sense to open up the possibility to store a third successor block?
iluuu1994
reviewed
Sep 30, 2025
| int level; /* steps away from the entry in the dom. tree, or -1 */ | ||
| int children; /* list of dominated blocks, or -1 */ | ||
| int next_child; /* next dominated block, or -1 */ | ||
| int successors_storage[2]; /* up to 2 successor blocks */ |
Girgias
force-pushed
the
opcache-uint32
branch
from
05cfc00 to
8ab7291
Compare
iluuu1994
approved these changes
Oct 1, 2025
…ange The previous commit allows us to propagate the type change to various functions that return a value derived from _zend_call_info.num_args
…r variable storing result of zend_bitset_len()
Girgias
force-pushed
the
opcache-uint32
branch
from
7dbbb4e to
103892c
Compare
This was referenced Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somewhat a continuation of #19479 to work towards addressing #19479 (comment)