opcache: Fix segfault in function JIT due to NAN to bool warning #19947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluuu1994
approved these changes
Sep 24, 2025
ext/opcache/jit/zend_jit_ir.c
Outdated
| ir_ref if_val = ir_IF(is_nan); | ||
| ir_IF_TRUE_cold(if_val); | ||
| jit_SET_EX_OPLINE(jit, opline); | ||
| ir_CALL(IR_VOID, ir_CONST_FC_FUNC(zend_jit_nan_coerced_to_type_warning)); |
There was a problem hiding this comment.
Nit: This file doesn't indent branches anywhere, not sure it makes sense to start a new convention for 2 lines. 😄
There was a problem hiding this comment.
That's fair, I did it so that I could understand what is going on, but can remove the indent :)
Girgias
added a commit
that referenced
this pull request
Sep 24, 2025
* PHP-8.5: Update NEWS opcache: Fix segfault in function JIT due to NAN to bool warning (#19947)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.