Deref property after FETCH_OBJ_R with REG destination #19838
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll pull this fix to test with my application later 👍🏻 |
|
Can confirm this fixes my application's issue 👍🏻 |
iluuu1994
reviewed
Sep 16, 2025
dstogov
approved these changes
Sep 22, 2025
|
Edit: Issue disappeared after recompiling to PHP-8.4 branch tip. Possibly might've had a bad build from another branch 🤦🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for GH-19831.
zend_jit_fetch_obj_r_slow_exdoesn't deref the property.Tracing JIT is unaffected due to type guards.
I believe that other variants of
zend_jit_fetch_obj_*_slow_excan not be used used in function JIT.