Fix OpenSSL fetching of alias ciphers #19437
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not seem like an issue as the aliases seem to be already fetched most of the time. But there might be cases when it could be failing like it was failing for MD in phpGH-19369. It should be noted that the test does not fail without this change but it seems useful anyway so it is added as part of this change. I actually have not found the case where alias is not fetched for cipher but there might be some.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not seem like an issue as the aliases seem to be already fetched most of the time. But there might be cases when it could be failing like it was failing for MD in GH-19369.
It should be noted that the test does not fail without this change but it seems useful anyway so it is added as part of this change. I actually have not found the case where alias is not fetched for cipher but there might be some.