Skip to content

Fix GH-19197: session build fails on system with memcpy as macro. #19198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2025
Merged

Fix GH-19197: session build fails on system with memcpy as macro. #19198

merged 1 commit into from
Jul 21, 2025
+2 −2

Conversation

devnexen
Copy link
Member

Thus ZEND_STRL macro does not expand as expected so going back to not using it like lower branches.

@devnexen
Fix phpGH-19197: session build fails on system with memcpy as macro.
c85b870 
Thus ZEND_STRL macro does not expand as expected so going back
to not using it like lower branches.
@devnexen devnexen requested a review from Girgias as a code owner July 21, 2025 08:10
@devnexen devnexen linked an issue Jul 21, 2025 that may be closed by this pull request
php-8.5.0alpha2 build failure in ext/session/session.c #19197
Closed
nielsdos
nielsdos approved these changes Jul 21, 2025
View reviewed changes
Copy link
Member

@nielsdos nielsdos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL memcpy can be implemented as a macro

@devnexen devnexen merged commit bd886d2 into php:master Jul 21, 2025
9 checks passed
@devnexen devnexen deleted the gh19197 branch July 21, 2025 09:19
@Girgias
Copy link
Member

Girgias commented Jul 21, 2025

TIL memcpy can be implemented as a macro

Same, might need to check all usages of ZEND_STRL just to make sure it isn't in a memcpy

@devnexen
Copy link
Member Author

devnexen commented Jul 21, 2025 •
edited
Loading

TIL memcpy can be implemented as a macro

Same, might need to check all usages of ZEND_STRL just to make sure it isn't in a memcpy

I do not think there is any left, nor do I know if any libc/os implements strncmp as macro but in case you might roll back this one if you wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nielsdos nielsdos nielsdos approved these changes

@Girgias Girgias Awaiting requested review from Girgias Girgias is a code owner

Assignees

No one assigned

Labels

Extension: session

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

php-8.5.0alpha2 build failure in ext/session/session.c

3 participants

@devnexen @Girgias @nielsdos