Skip to content

streams: Various minor refactorings #19106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Aug 4, 2025
Merged

streams: Various minor refactorings #19106

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8a232b4
streams: add const specifier
Girgias Jul 12, 2025
837ab97
streams: reduce scope of variables
Girgias Jul 12, 2025
1847239
streams: use type bool instead of type int
Girgias Jul 12, 2025
b322edd
streams: use type zend_result instead of type int
Girgias Jul 12, 2025
95c50e4
streams: use type size_t instead of type unsigned int
Girgias Jul 12, 2025
663c67e
streams: use int type instead of long
Girgias Jul 12, 2025
96299cc
streams: use precomputed persistant variable
Girgias Jul 12, 2025
14ed8cf
streams: remove confusing step variable
Girgias Jul 12, 2025
ff8fa7a
streams: use -1 directly instead of FAILURE macro
Girgias Jul 12, 2025
2772f73
streams: use call in if statement directly
Girgias Jul 12, 2025
a65efe3
streams: remove useless casts
Girgias Jul 12, 2025
f0f2a17
streams: refactor implementation of stream_select()
Girgias Jul 12, 2025
e0b4e2f
streams: use RETURN_BOOL() when possible
Girgias Jul 12, 2025
59a9975
streams: voidify php_stream_filter_prepend_ex()
Girgias Jul 12, 2025
c0cacef
streams: drop unused includes
Girgias Jul 12, 2025
37bfd3d
streams: use an enum for return type of _php_stream_make_seekable()
Girgias Jul 12, 2025
f16cf77
streams: use %zu printf specifier for size_t
Girgias Jul 12, 2025
7af46fd
streams: use type php_socket_t instead of type int
Girgias Jul 12, 2025
0db4f60
streams: refactor statbuf_from_array()
Girgias Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
streams: use type size_t instead of type unsigned int
  • Loading branch information
@Girgias
Girgias committed Jul 12, 2025
commit 95c50e492937ecfdcf9c2e8a11557e2eaa45dcee
6 changes: 2 additions & 4 deletions main/streams/streams.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,11 +1903,9 @@ void php_shutdown_stream_wrappers(int module_number)
/* Validate protocol scheme names during registration
* Must conform to /^[a-zA-Z0-9+.-]+$/
*/
static inline zend_result php_stream_wrapper_scheme_validate(const char *protocol, unsigned int protocol_len)
static inline zend_result php_stream_wrapper_scheme_validate(const char *protocol, size_t protocol_len)
{
unsigned int i;

for(i = 0; i < protocol_len; i++) {
for (size_t i = 0; i < protocol_len; i++) {
if (!isalnum((int)protocol[i]) &&
protocol[i] != '+' &&
protocol[i] != '-' &&
Expand Down