Skip to content

random: Remove useless zend_string allocation in randomizer_common_init() #19007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

random: Remove useless zend_string allocation in randomizer_common_init() #19007

merged 1 commit into from
Jul 3, 2025
+1 −8

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Jul 2, 2025

No description provided.

@TimWolla TimWolla requested a review from zeriyoshi as a code owner July 2, 2025 10:44
Girgias
Girgias approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively moving the zstr allocation into the hash function, but that's fine.

@TimWolla
Copy link
Member Author

TimWolla commented Jul 2, 2025

Effectively moving the zstr allocation into the hash function,

No. zend_hash_str_find_ptr won't allocate internally.

@Girgias
Copy link
Member

Girgias commented Jul 2, 2025

Effectively moving the zstr allocation into the hash function,

No. zend_hash_str_find_ptr won't allocate internally.

TIL

@TimWolla TimWolla merged commit 4492a42 into php:master Jul 3, 2025
9 checks passed
@TimWolla TimWolla deleted the random-remove-useless-zend-string branch July 3, 2025 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias approved these changes

@zeriyoshi zeriyoshi Awaiting requested review from zeriyoshi zeriyoshi is a code owner

Assignees
No one assigned
Labels
Extension: random
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimWolla @Girgias