ext/sqlite3: Sqlite3Result::fetchAll() #18884
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
support associative and indexes arrays for results.
devnexen
force-pushed
the
sqlite_fetch_all
branch
from
3510530 to
1245997
Compare
ext/sqlite3/sqlite3.c
Outdated
Comment on lines
2047
to
2066
| zval result; | ||
| array_init_size(&result, result_obj->column_count); | ||
|
|
||
| for (i = 0; i < result_obj->column_count; i ++) { | ||
| zval data; | ||
| sqlite_value_to_zval(result_obj->stmt_obj->stmt, i, &data); | ||
|
|
||
| if (mode & PHP_SQLITE3_NUM) { | ||
| add_index_zval(&result, i, &data); | ||
| } | ||
|
|
||
| if (mode & PHP_SQLITE3_ASSOC) { | ||
| if (mode & PHP_SQLITE3_NUM) { | ||
| if (Z_REFCOUNTED(data)) { | ||
| Z_ADDREF(data); | ||
| } | ||
| } | ||
| zend_symtable_update(Z_ARR_P(&result), result_obj->column_names[i], &data); | ||
| } | ||
| } |
There was a problem hiding this comment.
This part of the code is almost identical to fetchArray() and is therefore redundant. How about consolidating it into an inline function or something similar?
SakiTakamachi
approved these changes
Jun 23, 2025
|
This was merged via 375316d wasn't it? Please confirm and close this PR if so. |
|
indeed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support associative and indexes arrays for results.