-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Add Lexbor files for URL handling #18656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The build failure seems legit, the definition is missing a field:
Although legal, our build system is more strict. It should be fixed in upstream. I'll get that sorted: lexbor/lexbor#280 |
Thanks for the investigation! I was about to ask whether I can suppress the error or not (and actually, I've just pushed the suppress). But then I'll wait for the fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For visibility, officially requesting changes for lxb_url_serialize_unicode()
. It should either be upstreamed or added to the patch files.
I temporarily got rid of the custom code inside lexbor so that this PR could be merged immediately (and I can continue working on the next PR containing the WHATWG API). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that the files match lexbor/lexbor@506ae05. For the config.m4 / config.w32 changes I trust that you tested them.
Rebased the PR on top of current master (so that ext/uri related changes are there) + added a very small change (alphabetical ordering fix) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed that the ext/lexbor/lexbor files are unmodified since my last approval.
Relates to #14461 and https://wiki.php.net/rfc/url_parsing_api