Skip to content

Add Lexbor files for URL handling #18656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 27, 2025
Merged

Add Lexbor files for URL handling #18656

merged 7 commits into from
May 27, 2025

Conversation

kocsismate
Copy link
Member

@nielsdos
Copy link
Member

The build failure seems legit, the definition is missing a field:

{0, LXB_UNICODE_QUICK__UNDEF, 0, 0, 0},

Although legal, our build system is more strict. It should be fixed in upstream. I'll get that sorted: lexbor/lexbor#280

@kocsismate
Copy link
Member Author

The build failure seems legit, the definition is missing a field:

Thanks for the investigation! I was about to ask whether I can suppress the error or not (and actually, I've just pushed the suppress). But then I'll wait for the fix

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For visibility, officially requesting changes for lxb_url_serialize_unicode(). It should either be upstreamed or added to the patch files.

@kocsismate
Copy link
Member Author

kocsismate commented May 27, 2025

For visibility, officially requesting changes for lxb_url_serialize_unicode(). It should either be upstreamed or added to the patch files.

I temporarily got rid of the custom code inside lexbor so that this PR could be merged immediately (and I can continue working on the next PR containing the WHATWG API).

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that the files match lexbor/lexbor@506ae05. For the config.m4 / config.w32 changes I trust that you tested them.

@kocsismate
Copy link
Member Author

Rebased the PR on top of current master (so that ext/uri related changes are there) + added a very small change (alphabetical ordering fix)

Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the ext/lexbor/lexbor files are unmodified since my last approval.

@kocsismate kocsismate merged commit 400b7b8 into php:master May 27, 2025
8 of 9 checks passed
@kocsismate kocsismate deleted the ext-url3 branch May 27, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants