ext/gd: return void for couple of calls returning true when success is

[devnexen]

guaranteed.

[Girgias]

This is a BC break. As if (call_to_function_always_returning_true()) {} will never be called now.

[bukka]

I don't think this is worth it.

[devnexen]

I don't think this is worth it.

It made sense "back in the day", here php 4 used to return false on failure like this

ZEND_FETCH_RESOURCE(im, gdImagePtr, IM, -1, "Image", le_gd);

[Girgias]

If we are going to do something like this, then it probably should be done in PHP 9 and across all functions/methods.

[devnexen]

yes I agree, we started to discuss it in the internals.