Minor tweaks #1864
Merged
Minor tweaks #1864
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few unused variables removed. One ambiguous situation resolved. `join(...)` > `implode(...)`. One case of 2 `isset()` statements combined together.
| if ($compression && in_array("compress.zlib", stream_get_filters())) { | ||
| $output_file = 'compress.zlib://' . $output_file . '.gz'; | ||
| } | ||
|
|
There was a problem hiding this comment.
Dumb question: why did you remove the compression support?
There was a problem hiding this comment.
If you look few lines higher, $compression variable is always 0, so this code is basically dead.
There was a problem hiding this comment.
Well, obviously the question was really dumb. :)
I'll have a closer look at this PR within the next days. At least some clean up of the script seems indeed overdue.
|
The rest looks definitely fine to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Few unused variables removed.
One ambiguous situation resolved.
join(...)>implode(...).One case of 2
isset()statements combined together.P.S. I'm curious if anyone would love to see this thing refactored to something understandable (even keeping in single file) or it would be a waste of time?